Close tab on middle-click (#9699)#9767
Open
pavanmanishd wants to merge 3 commits intopgadmin-org:masterfrom
Open
Close tab on middle-click (#9699)#9767pavanmanishd wants to merge 3 commits intopgadmin-org:masterfrom
pavanmanishd wants to merge 3 commits intopgadmin-org:masterfrom
Conversation
Add onMouseDown handler to the tab close button that fires layoutDocker.close() when mouse button 1 (middle click) is pressed. preventDefault() stops the browser's auto-scroll cursor from appearing. This matches the standard UX in Chrome, Firefox, and VS Code where middle-click on a tab closes it.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a middle-click handler to tab titles: when a closable tab is middle-clicked (mouse button 1), the event is prevented and the tab is closed via Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TabTitle
participant LayoutDocker
participant LayoutUI
User->>TabTitle: middle-click (mouse button 1)
TabTitle->>TabTitle: onMouseDown handler\ncheck closable && e.button === 1
TabTitle-->>User: e.preventDefault()
TabTitle->>LayoutDocker: close(id)
LayoutDocker->>LayoutUI: remove tab / update layout
LayoutUI-->>User: UI updated (tab closed)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9699
Enable middle-click tab close behavior by handling mouse button 1 on the tab title and closing the tab when it is closable.
preventDefault()is used to avoid browser auto-scroll on middle click.Summary by CodeRabbit